fix(subturn): inherit runtime tool registry for spawned subagents#2020
Open
Alix-007 wants to merge 2 commits intosipeed:mainfrom
Open
fix(subturn): inherit runtime tool registry for spawned subagents#2020Alix-007 wants to merge 2 commits intosipeed:mainfrom
Alix-007 wants to merge 2 commits intosipeed:mainfrom
Conversation
sipeed-bot
bot
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1713.
This PR keeps spawned/subagent child turns aligned with the parent turn's runtime tool registry, instead of pre-snapshotting tools into
SubTurnConfig.Tools.spawn/subagentnow leaveSubTurnConfig.Toolsunset (nil) so child turns inherit at execution time from the parent turn context.spawnSubTurnnow prioritizes cloningbaseAgent.Toolswhen available, preserving registry semantics (including hidden tools and TTL gating).cfg.Toolsis only used as a fallback when the parent registry is unavailable and the explicit slice is non-empty.Why
The bug report describes spawned subagents missing tool definitions in provider requests. The robust fix is to inherit from the live parent registry so child turns receive the same tool visibility and runtime additions as the parent, while keeping hidden/TTL behavior intact.
Validation
Focused tests were added/updated to assert provider-level tool definitions and edge cases:
TestSpawnSubTurn_EmptyExplicitToolsStillInheritParentRegistryTestSpawnSubTurn_InheritsRuntimeAddedToolsTestSpawnSubTurn_PreservesHiddenTTLSemanticsTestSpawnSubTurn_UsesExplicitToolsWhenParentRegistryUnavailableTestSpawnTool_Execute_LeavesToolsUnsetForRuntimeInheritanceTestSubagentTool_Execute_LeavesToolsUnsetForRuntimeInheritanceCommands run:
go test ./pkg/tools -run 'TestSpawnTool_Execute_(ValidTask|LeavesToolsUnsetForRuntimeInheritance)|TestSubagentTool_Execute_(Success|LeavesToolsUnsetForRuntimeInheritance)' -count=1\n-go test ./pkg/agent -run 'TestSpawnSubTurn_(EmptyExplicitToolsStillInheritParentRegistry|InheritsRuntimeAddedTools|PreservesHiddenTTLSemantics|UsesExplicitToolsWhenParentRegistryUnavailable)' -count=1\n-go test ./pkg/tools -run 'TestSpawnTool_|TestSubagentTool_' -count=1\n-go test ./pkg/agent -run 'TestSpawnSubTurn_' -count=1